add http proxy settings #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igrishaev
reviewed
Jul 29, 2020
README.md
Outdated
| :pac-url "localhost:8888" ;; explore this for using proxy in safari | ||
| :ftp "some.proxy.com:8080" | ||
| :ssl "some.proxy.com:8080" | ||
| :socks {:host "myproxy:8080" :version 5} |
There was a problem hiding this comment.
тут лучше порт 1080, это стандарт для сокс
igrishaev
reviewed
Jul 29, 2020
igrishaev
reviewed
Jul 29, 2020
README.md
Outdated
|
|
||
| ``` clojure | ||
| {:proxy {:http "some.proxy.com:8080" | ||
| :pac-url "localhost:8888" ;; explore this for using proxy in safari |
There was a problem hiding this comment.
pac-url лучше сдвинуть в конец мапы и добавить коммент:
A url for a proxy autoconfiguration file. Used with Safari as the other proxy options do not work in that browser.
И ссылку на вики:
https://en.wikipedia.org/wiki/Proxy_auto-config#The_PAC_File
igrishaev
reviewed
Jul 29, 2020
igrishaev
reviewed
Jul 29, 2020
src/etaoin/api.clj
Outdated
| @@ -2884,6 +2896,12 @@ | |||
| [with height] size | |||
| log-level (or log-level :all) | |||
| path-driver (or path-driver (get-in defaults [type :path])) | |||
| proxy (or proxy | |||
There was a problem hiding this comment.
подход верный, только лучше в отдельной функции типа proxy-env. Она принимает proxy и дополняет переменными среды через cond->
There was a problem hiding this comment.
Она принимает proxy, не получится что она затрет параметры которые мануально передали?
igrishaev
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#fixies #148