better free port discovery #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igrishaev
reviewed
Jul 23, 2020
src/etaoin/api.clj
Outdated
| @@ -1821,9 +1821,9 @@ | |||
| Returns a port as an integer." | |||
| [type host] | |||
| (loop [port (or (get-in defaults [type :port]) | |||
| (util/random-port))] | |||
| (util/get-free-port))] | |||
| (if (connectable? host port) | |||
There was a problem hiding this comment.
функцию connectable? лучше перенести в utils, потому что она не относится к api.
There was a problem hiding this comment.
она заявязана на макрос который объявлен в api, если перенести будет циклическая зависимость
igrishaev
reviewed
Jul 23, 2020
src/etaoin/api.clj
Outdated
| (defn running? | ||
| "Check whether a driver runs HTTP server." | ||
| [driver] | ||
| (connectable? (:host @driver) | ||
| (util/connectable? (:host @driver) | ||
| (:port @driver))) |
There was a problem hiding this comment.
тут выровнять второй аргумент
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#fixes #240