Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add select fn #241

Merged
merged 2 commits into from
Jul 22, 2020
Merged

add select fn #241

merged 2 commits into from
Jul 22, 2020

Conversation

Uunnamed
Copy link
Contributor

#fixes #239

igrishaev
igrishaev reviewed Jul 22, 2020
View reviewed changes
src/etaoin/api.clj Outdated

- `text`: a string to input."
[driver q text]
(let [el (query driver q {:fn/has-text text})]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Только наверное добавить тег: {:tag :option :fn/has-text text}. И на всякий уточню: поиск сработает внутри селектора q, правильно?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. точно, ок поправлю сейчас.
  2. да

@igrishaev igrishaev merged commit c72a784 into master Jul 22, 2020
@igrishaev igrishaev deleted the add-select-fn branch July 22, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igrishaev igrishaev igrishaev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add select fn by visible text
2 participants
@Uunnamed @igrishaev