Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User defaults for default-timeout default-interval default-locator #160

Closed
snoe opened this issue Jul 6, 2018 · 3 comments
Closed

User defaults for default-timeout default-interval default-locator #160

snoe opened this issue Jul 6, 2018 · 3 comments
Assignees
@Uunnamed

Comments

@snoe
Copy link

snoe commented Jul 6, 2018

It would be nice if it was possible for user code to be able to specify their own default-* values in the api. This could probably be done with ^:dynamic vars.

As it stands a 30 second timeout is too long for our particular use case and it would be nice not to have pass in opts to all the wait api calls.
@igrishaev
Copy link
Collaborator

agree, we'll take this in work

@igrishaev igrishaev self-assigned this Aug 6, 2020
@igrishaev
Copy link
Collaborator

@Uunnamed create global dynamic vars and some macros like (with-locator ...), (with-wait-timeout) etc. Add to readme

@igrishaev igrishaev assigned Uunnamed and unassigned igrishaev Aug 6, 2020
@Uunnamed Uunnamed mentioned this issue Aug 7, 2020
Merged
@igrishaev
Copy link
Collaborator

@snoe We've added the with-wait-timeout and with-wait-interval macros, they will be in the release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Uunnamed Uunnamed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@snoe @igrishaev @Uunnamed