Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for external data variables with > 2 dimensions #47

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

chrispcampbell
Copy link
Contributor

The primary change here was to generalize the code that handles subscripted external data variables so that it works for any number of dimensions. That also helped make the code more succinct.

I extended the extdata test case to include a 3-dimensional data variable and added a VECTOR SELECT scenario that mimics something in the En-ROADS model. That uncovered a bug where SDE was not emitting a LOOKUP call when the external data variable is referenced inside a VECTOR SELECT. I fixed that in visitVar so that we use some existing code that emits a LOOKUP when a data variable is used inside VECTOR SELECT.

Fixes #45

@chrispcampbell chrispcampbell merged commit 6683e63 into develop Sep 17, 2020
@chrispcampbell chrispcampbell deleted the ccampbell/45-multi-dim-ext-data branch September 17, 2020 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for external data variables with > 2 dimensions
1 participant