feat: add support for additional trig functions #383
Conversation
chrispcampbell
changed the title
There was a problem hiding this comment.
Looks great, thanks!
I added the 4 new functions to the Supported Vensim Functions page on the wiki.
I'll also make sure the new functions are covered in the new unit tests that are currently out for review in another PR.
|
I think the GH Actions are not running correctly for PRs submitted from a fork. I'll look into that and make sure builds are working before I merge this. |
|
I'm going to move back to working in the main repo now unless it is useful for me to test using forks for collaboration. |
|
This PR was useful for verifying that we can accept contributions via fork. There was one other PR submitted (that is on hold) and it had the same issue with GH Actions not running, so this was good for getting me to investigate. |
|
I fixed the issue that prevented the build workflow running, and the build was successful, so I'll merge this. |
Fixes #382
Added TAN, ARCSIN, ARCCOS, and ARCTAN function support to SDE. Included tests.