Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix LOOKUP FORWARD to correctly handle fractional inputs #38

Merged
merged 1 commit into from
Sep 12, 2020
Merged

fix: fix LOOKUP FORWARD to correctly handle fractional inputs #38

merged 1 commit into from
Sep 12, 2020

Conversation

chrispcampbell
Copy link
Contributor

This fixes __lookup behavior for Forward mode and adds more cases to the existing lookup model test to make sure we've covered everything.

Fixes #36

@chrispcampbell chrispcampbell merged commit c1f9580 into develop Sep 12, 2020
@chrispcampbell chrispcampbell deleted the ccampbell/36-lookup-forward branch September 12, 2020 00:48
travisfranck
travisfranck reviewed Sep 21, 2020
View reviewed changes
Copy link
Collaborator

@travisfranck travisfranck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't understand this one.

@climateinteractive-bot climateinteractive-bot mentioned this pull request Jun 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisfranck travisfranck travisfranck left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LOOKUP FORWARD produces incorrect results with fractional input
2 participants
@chrispcampbell @travisfranck