Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrap conditional branch expression in parentheses when optimizing IF THEN ELSE #153

Merged
merged 3 commits into from
Oct 28, 2021
Merged

fix: wrap conditional branch expression in parentheses when optimizing IF THEN ELSE #153

merged 3 commits into from
Oct 28, 2021

Conversation

chrispcampbell
Copy link
Contributor

Fixes #152

ToddFincannon
ToddFincannon approved these changes Oct 26, 2021
View reviewed changes
Copy link
Collaborator

@ToddFincannon ToddFincannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — looks pretty straightforward to me.

@chrispcampbell chrispcampbell merged commit bd42d54 into develop Oct 28, 2021
@chrispcampbell chrispcampbell deleted the chris/152-if-then-else-parens branch October 28, 2021 19:50
@climateinteractive-bot climateinteractive-bot mentioned this pull request Jun 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToddFincannon ToddFincannon ToddFincannon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parentheses omitted when IF THEN ELSE optimization is applied
2 participants
@chrispcampbell @ToddFincannon