Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use chunkedFunction to break up initLookups into smaller functions #133

Merged
merged 3 commits into from
Oct 14, 2021
Merged

fix: use chunkedFunction to break up initLookups into smaller functions #133

merged 3 commits into from
Oct 14, 2021

Conversation

ToddFincannon
Copy link
Collaborator

@ToddFincannon ToddFincannon commented Oct 8, 2021 •
edited by chrispcampbell
Loading

Fixes #132

@ToddFincannon ToddFincannon added this to the 0.6.0 milestone Oct 8, 2021
@chrispcampbell chrispcampbell changed the title use chunkedFunction to break up initLookups into smaller functions fix: use chunkedFunction to break up initLookups into smaller functions Oct 8, 2021
chrispcampbell
chrispcampbell approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@chrispcampbell chrispcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ToddFincannon Looks good to me. Will merge shortly.

@chrispcampbell chrispcampbell merged commit bad4580 into develop Oct 14, 2021
@chrispcampbell chrispcampbell deleted the todd/132-init-lookups branch October 14, 2021 03:31
@climateinteractive-bot climateinteractive-bot mentioned this pull request Jun 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrispcampbell chrispcampbell chrispcampbell approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

Large initLookups function crashes on entry
2 participants
@ToddFincannon @chrispcampbell