perf: optimize IF THEN ELSE for cases where condition expression resolves to a constant #103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102
See issue for more details. I updated the existing
prune
test (which is used to verify the unused reference elimination code) with new cases to cover theIF THEN ELSE
optimizations.At some point I'd like to reimplement the equation reader phase to produce objects that are AST-like, and then have the code gen phase use those objects instead of revisiting the whole model structure. That way optimizations like this and the dead code elimination (and others we could do, like constant folding) could be expressed as AST transforms. But that's for another day (probably way down the road). For now, I think this gets the job done, and wasn't too terribly invasive.