fix(dia.Cell): prevent exception when removeProp() called on non-exis…

…ting top-level attribute (#1898)
clientIO · Nov 18, 2022 · f983f8d · f983f8d
1 parent 9cdc6a1
commit f983f8d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/dia/Cell.mjs b/src/dia/Cell.mjs
@@ -601,7 +601,9 @@ export const Cell = Backbone.Model.extend({
 
         // A nested property
         var nestedPath = pathArray.slice(1);
-        var propertyValue = cloneDeep(this.get(property));
+        var propertyValue = this.get(property);
+        if (propertyValue === undefined || propertyValue === null) return this;
+        propertyValue = cloneDeep(propertyValue);
 
         unsetByPath(propertyValue, nestedPath, '/');
 

diff --git a/test/jointjs/cell.js b/test/jointjs/cell.js
@@ -250,6 +250,12 @@ QUnit.module('cell', function(hooks) {
                 assert.deepEqual(attributes.a[1], { cc: 'cc' });
             });
 
+            QUnit.test('remove non-existing top-level property', function(assert) {
+
+                el.removeProp('a/b/c');
+                assert.equal(attributes.a, undefined);
+            });
+
             QUnit.module('define path as an array', function(hooks) {
 
                 QUnit.test('remove item from array', function(assert) {