forked from microsoft/vscode
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update fork #8
Merged
Merged
update fork #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I cannot reproduce the problem when running out of source, so I could not really verify that the fix works. `environmentService.debugExtensionHost.break` is used for two things: 1) as an indication that debug mode is active and 2) it indicates that break mode is active. The first use is now broken, because debug mode can be enabled with the command line flag `--debugPluginHost` too. This dual use forbids that we can just add a test for `--debugPluginHost` when parsing the value from the command line. For this reason I'm following @bpasero's suggestion to use the `debugExtensionHost.port` as an indication that debug mode is active.
prevent reload window closes the debuggee; fixes #23390
Listen on configuration change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.