Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update fork #8

Merged
merged 116 commits into from
Mar 31, 2017
Merged

update fork #8

merged 116 commits into from
Mar 31, 2017

Conversation

cleidigh
Copy link
Owner

No description provided.

joaomoreno and others added 30 commits March 28, 2017 09:04
I cannot reproduce the problem when running out of source, so I could not really verify that the fix works.

`environmentService.debugExtensionHost.break` is used for two things: 1) as an indication that debug mode is active and 2) it indicates that break mode is active. The first use is now broken, because debug mode can be enabled with the command line flag `--debugPluginHost` too.  This dual use forbids that we can just add a test for `--debugPluginHost` when parsing the value from the command line. For this reason I'm following @bpasero's suggestion to use the `debugExtensionHost.port` as an indication that debug mode is active.
prevent reload window closes the debuggee; fixes #23390
joaomoreno and others added 29 commits March 30, 2017 21:33
- Opening keybindings
- While performing actions
@cleidigh cleidigh merged commit 4743fb1 into cleidigh:master Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.