Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixer build delta-packs can break delta creations when using --previous-versions #779

Open
phmccarty opened this issue Aug 30, 2022 · 0 comments
Labels

Comments

@phmccarty
Copy link
Contributor

phmccarty commented Aug 30, 2022

When running mixer build delta-packs --previous-versions=N, packs will be generated for the previous N versions, as expected. But the delta list and delta creations for each previous version are processed independently, and in parallel, which often leads to unexpected bsdiff delta creation/application failures when delta lists overlap (i.e. contain duplicates if the lists were combined).

Instead, I think it would be better for mixer to (a) compute the delta list for the previous N versions (de-duplicated), (b) create all deltas from the delta list in parallel, and finally (c) create the delta packs.

The entrypoint for this process is:

func (b *Builder) BuildDeltaPacksPreviousVersions(prev, to uint32, printReport bool) error {

@phmccarty phmccarty added the bug label Aug 30, 2022
@phmccarty phmccarty changed the title mixer build delta-packs should de-duplicate delta list when using --previous-versions mixer build delta-packs can break delta creations when using --previous-versions Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant