Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make check fails on Fedora 21 due to using gdk-pixbuf 2.31.1 #19

Closed
mtasaka opened this issue Jan 14, 2015 · 3 comments
Closed

make check fails on Fedora 21 due to using gdk-pixbuf 2.31.1 #19

mtasaka opened this issue Jan 14, 2015 · 3 comments

Comments

@mtasaka
Copy link

mtasaka commented Jan 14, 2015

Now on Fedora 21 (already released) make check (on both cutter 1.2.4 and git head) fails like:

===============================================================================
Failure: test_inspect
<expected == gcut_object_inspect(G_OBJECT(pixbuf1))>
expected: <"#<GdkPixbuf:0x97c1958 colorspace=<#<GdkColorspace: rgb(GDK_COLORSPACE_RGB:0)>>, n-channels=<4>, has-alpha=<TRUE>, bits-per-sample=<8>, width=<100>, height=<100>, rowstride=<400>, pixels=<((gpointer) 0x98b56c8)>>">
  actual: <"#<GdkPixbuf:0x97c1958 colorspace=<#<GdkColorspace: rgb(GDK_COLORSPACE_RGB:0)>>, n-channels=<4>, has-alpha=<TRUE>, bits-per-sample=<8>, width=<100>, height=<100>, rowstride=<400>, pixels=<((gpointer) 0x98b56c8)>, pixel-bytes=<NULL>>">

diff:
? "#<GdkPixbuf:0x97c1958 colorspace=<#<GdkColorspace: rgb(GDK_COLORSPACE_RGB:0)>>, n-channels=<4>, has-alpha=<TRUE>, bits-per-sample=<8>, width=<100>, height=<100>, rowstride=<400>, pixels=<((gpointer) 0x98b56c8)>, pixel-bytes=<NULL>>"

./gdkcutter-pixbuf/test-gdkcut-pixbuf.c:143: test_inspect(): cut_assert_equal_string_with_free(expected, gcut_object_inspect(((((GObject*) g_type_check_instance_cast ((GTypeInstance*) ((pixbuf1)), (((GType) ((20) << (2))))))))), )
===============================================================================

(and now cutter srpm on Fedora FTBFS (fail to build from source) on Fedora 21, 22)

I guess this is due to this commit (and bug report):
https://git.gnome.org/browse/gdk-pixbuf/commit/?id=862e3890f54aaeb8589a6ee4c146f1fb50556004
https://bugzilla.gnome.org/show_bug.cgi?id=732297

Current "unstable" GdkPixbuf API:
https://developer.gnome.org/gdk-pixbuf/unstable/gdk-pixbuf-The-GdkPixbuf-Structure.html#GdkPixbuf--pixel-bytes

I think it is safe that 2.31.1 and above has "pixel-bytes”.

P.S. first of all Fedora 21 should not use such an "unstable" stage of gdk-pixbuf2, I think :( however that happened...

@mtasaka
Copy link
Author

mtasaka commented Jan 14, 2015

I think it is safe that 2.31.1 and above has "pixel-bytes”.
meant I think it is safe to think that 2.31.1 and above has "pixel-bytes”.

@mtasaka mtasaka changed the title make test fails on Fedora 21 due to using gdk-pixbuf 2.31.1 make check fails on Fedora 21 due to using gdk-pixbuf 2.31.1 Jan 14, 2015
@kou kou closed this as completed in 1c1c3e6 Jan 15, 2015
@kou
Copy link
Member

kou commented Jan 15, 2015

Thanks for your report.
I've fixed it.

I confirmed that gdk-pixbuf 2.31.0 has "pixel-bytes".

@mtasaka
Copy link
Author

mtasaka commented Jan 16, 2015

Confirmed, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants