Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: support variadics with @param #26

Open
Whax opened this issue Jul 17, 2023 · 1 comment
Open

FR: support variadics with @param #26

Whax opened this issue Jul 17, 2023 · 1 comment

Comments

@Whax
Copy link

Whax commented Jul 17, 2023

Hello,

I'm on neovim using treesitter and I'm encountering the following issue :

image

As you can see, the Variadic param type is not correctly recognized. It's considered as @spell

image

instead of @type.phpdoc

image

@Whax Whax changed the title Variadic @param Variadic @param not recognized as type, only as spell Jul 17, 2023
@claytonrcarter
Copy link
Owner

The @spell part is coming from neovim; that's not something that is added or related this grammar. I can confirm, though, that variadic params aren't supported. (In this case, ...$attributes is being parsed as if it were a description of the param, which is probably why neovim is saying that it needs spellchecking (I assume that's what @spell if for).)

I would welcome a PR that adds support for variadic params.

@claytonrcarter claytonrcarter changed the title Variadic @param not recognized as type, only as spell FR: support variadics with @param Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants