Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirects should take into account the current site #557

Closed
pedro-rosario opened this issue Jul 6, 2018 · 1 comment
Closed

Redirects should take into account the current site #557

pedro-rosario opened this issue Jul 6, 2018 · 1 comment

Comments

@pedro-rosario
Copy link
Contributor

Given this route for selectall { path: '/smarthome', redirect: '/smarthome/'}, you would expect to be redirected from nymag.com/selectall/smarthome to nymag.com/selectall/smarthome/ but instead it goes to nymag.com/smarthome/. This is because there is no way to get the current site you are in and add it to the redirect, forcing you to write the route like this { path: '/smarthome', redirect: '/selectall/smarthome/'}.

@nelsonpecora
Copy link
Contributor

Hmm! That's not good. They should definitely be prefixed with the site domain and path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants