Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for adding headers to a response in an amphora plugin #456

Closed
elgreg opened this issue Oct 17, 2017 · 4 comments
Closed

Allow for adding headers to a response in an amphora plugin #456

elgreg opened this issue Oct 17, 2017 · 4 comments
Labels

Comments

@elgreg
Copy link
Contributor

elgreg commented Oct 17, 2017

I'd like to be able to attach a list of all the _refs that are on a page (e.g. the article refs for each story card in the home page) as surrogate keys with fastly. @jonwinton suggested adding the ability to add plugins to rendering in amphora. I'd like to hook into the rendering of the homepage in amphora and add surrogate keys for all URLS of linked articles with a Surrogate-Key: header on the HTTP response

@TTaitFoster
Copy link

Why not just an express middleware?

@elgreg
Copy link
Contributor Author

elgreg commented Jan 28, 2019

I would prefer that I had access to the components themselves. So maybe this belongs in the renderer?

@jonwinton
Copy link
Contributor

Yes, completely agree. We'll move to amphora-html.

@jonwinton
Copy link
Contributor

Issue moved to clay/amphora-html #57 via ZenHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants