Implement proper account recovery #62
Conversation
|
Questions in regarding the recover process:
|
|
Good points. I was going to say "no" to both, but since emails aren't guaranteed to be unique this would pose a problem for username-based accounts. As such, I'm going to have to modify this to support username-based recovery requests. Thanks! |
|
Alright, apart from some minor things that are now temporarily failing, I believe this should account for the issue you brought up @Jubeki. Thanks again! |
|
|
||
| Route::middleware([])->group(function () { | ||
| Route::get('/auth/reset', ['foo', 'bar'])->name('recover-account.reset'); | ||
| }); |
There was a problem hiding this comment.
| Route::middleware([])->group(function () { | |
| Route::get('/auth/reset', ['foo', 'bar'])->name('recover-account.reset'); | |
| }); |
There was a problem hiding this comment.
Okay it seems the route is needed, but there is no Controller associated and an empty middleware array.
There was a problem hiding this comment.
Yeah, this is on purpose - hence the PR still being a draft. The actual 'reset' part is still TODO
|
Any updates on this one? |
|
@shane-smith Definitely! Work might not appear active on the repo at the moment, but I can ensure you it's very active in a separate (temporary) one 👍 @Jubeki and I have had extensive discussions about some of the problems we ran into with the approach we've taken so far, specifically surrounding account recovery with username-only accounts, which lead to essentially a rewrite of the current repository. It's 90-95% identical, but does a few things fundamentally different (e.g. no "username-based" or "email-based" accounts, both are possible now), and simultaneously addresses a couple of other issues that we ran into (and that are still TODO here in this "current version" of the repository). Right now I'd say it's about 70% done, and I expect work to complete (and be PR'd here) within a week or two. Once thoroughly tested, I expect to also tag v1.0.0 as a result. I'm genuinely super excited for it, as what we're working on so far feels so much better and more robust already. Can't wait to share the whole thing! But to give a bit of an impression; you can expect it to work almost identical to how Github's email & security management works :) |
|
Your excitement is palpable, I look forward to it :) |
This PR aims to solve #3
Closes #3