[IMPROVE] Detector smart-agent_haproxy

[dkmatt0]

What is the module?
https://github.com/claranet/terraform-signalfx-detectors/blob/master/modules/smart-agent_haproxy

What is the detector?
all detector in the module

Is your improvement related to a known monitoring limitations? Please describe.
Impossible to customize the command when (with a lasting_duration per example)

Describe the solution you'd like
Add variables in "when" command like this :

terraform-signalfx-detectors/modules/smart-agent_nginx-ingress/detectors-gen.tf

Line 15 in 3eae61b

detect(when(signal > ${var.latency_threshold_critical}, lasting=%{if var.latency_lasting_duration_critical == null}None%{else}'${var.latency_lasting_duration_critical}'%{endif}, at_least=${var.latency_at_least_percentage_critical})).publish('CRIT')

[xp-1000]

The best would be to simply use the generator to create this module.

this will fix the lasting absence but also any other lacks compared to our best practices