Add data_dir, manage_{user,group} as optional parameters in init.pp #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
install.pp expects a $consul_template::data_dir variable to exist. We will satisfy this expectation by adding it as a parameter in init.pp with a default value of ''.
install.pp is complaining about some additional unknown variables. This commit declares them in init.pp
|
Ooh lovely - if you're going to submit a PR full of tests then you're my favourite person :) |
gdhbashton
added a commit
that referenced
this pull request
Aug 28, 2015
Add data_dir, manage_{user,group} as optional parameters in init.pp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
consul_template::install requires some variables to work properly. However, the class takes no parameters. By adding them as optional parameters in init.pp, they can be passed in directly or via Hiera.
Currently, there are no tests for this class. A simple 'it { is_expected.to compile }' will unearth the problem. The trickier part of writing a test is that the class operates under the assumption that consul_template will be executed first, and that consul_template will include consul_template::install. This makes it difficult to write a spec that directly tests consul_template::install.