Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin clap_derive when making beta releases #2705

Closed
abonander opened this issue Aug 16, 2021 · 3 comments · Fixed by #2706
Closed

Pin clap_derive when making beta releases #2705

abonander opened this issue Aug 16, 2021 · 3 comments · Fixed by #2706
Labels
C-bug Category: Updating dependencies

Comments

@abonander
Copy link

abonander commented Aug 16, 2021

In sqlx-cli we were pinning the previous beta release of clap via the following:

clap = "=3.0.0-beta.2"

However, because clap itself does not pin the version of clap_derive, when 3.0.0-beta.4 was released with breaking changes it made our users unable to simply run cargo install sqlx-cli as clap 3.0.0-beta.2 was pulling in clap_derive 3.0.0-beta.4 which generated incompatible code: launchbadge/sqlx#1378

I'm already working on a fix on our end, adding clap_derive = "=3.0.0-beta.2" to sqlx-cli/Cargo.toml, but I just wanted to put this out there if you're planning any more beta releases before 3.0 proper, that you should consider pinning clap_derive to the same version when importing it in clap so beta users don't have to remember to pin them both to avoid breakages.

@pksunkara pksunkara added the C-bug Category: Updating dependencies label Aug 17, 2021
@pksunkara
Copy link
Member

Next time, please use the issue template.

@epage
Copy link
Member

epage commented Aug 17, 2021

For those curious, this Cargo behavior came up on internals back in June but seemed to fizzxle out: https://internals.rust-lang.org/t/changing-cargo-semver-compatibility-for-pre-releases/14820/12

@pksunkara
Copy link
Member

pksunkara commented Aug 18, 2021

Oh that would actually be nice. I always hated how npm treats pre releases. Adding this to my already long list of things to focus on after clap v3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: Updating dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants