Unsetting AllowInvalidUtf8 does nothing

[epage]

Please complete the following tasks

• I have searched the discussions
• I have searched the existing issues

Rust Version

rustc 1.53.0 (53cb7b09b 2021-06-17)

Clap Version

3.0.0-beta.2

Minimal reproducible code

app.unset_settings(AppSettings::AllowInvalidUtf8)

Steps to reproduce the bug with the above code

Pass in invalid UTF-8

Actual Behaviour

Its allowed

Expected Behaviour

Its rejected

Additional Context

I actually found this by inspection.

$ rg AllowInvalidUtf8
tests/app_settings.rs
598:    assert!(&m.is_set(AppSettings::AllowInvalidUtf8));
602:        .unset_global_setting(AppSettings::AllowInvalidUtf8)
604:    assert!(!m.is_set(AppSettings::AllowInvalidUtf8), "{:#?}", m);

src/build/app/settings.rs
83:    AllowInvalidUtf8("allowinvalidutf8")
197:    ///   //.setting(AppSettings::AllowInvalidUtf8)
215:    AllowInvalidUtf8,
1151:            AppSettings::AllowInvalidUtf8

And in AppSettings

    // TODO: Either this or StrictUtf8
    AllowInvalidUtf8,

Debug Output

No response

[hosseind88]

can anyone explain to me please what should I do to fix this issue?
I checked code but I don't understand what we should change about TODO

[epage]

I believe AllowInvalidUtf8 was being renamed to StrictUtf8 but the old name was left in. The name should probably be removed and people use StrictUtf8.

This needs to get added to the changelog to help people when upgrading from clap2 to clap3

[hosseind88]

thanks, I have submitted the PR