-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2-master branch is broken on 1.33 #1668
Comments
It isnt needed. Even if for some reason we need to push to 2.*, We can always start a new branch from the release |
I would actually like to backport at least simple bugfixes, like that one |
I will look into the v2-master branch and fix it today so that we can allow PRs to it. |
Yeah, I imagine many will choose to stay on v2.x for a while yet, so may need to be kept alive for some time. I hope that's ok to say, given I'm not volunteering. |
It is fine to say. But normally when a new version is released, it implicitly implies that previous version is no longer supported. |
I suspect it will be a while until 3.0 is released so we need to keep supporting 2.x until then at least |
So, I added the CIs and everything to v2-master which should make it easy for us to maintain it. The minimum version is now 1.36. I am closing this. |
MSRV for 2.x is 1.33, but current
v2-master
branch doesn't build with 1.33. Does it worth fixing it?The text was updated successfully, but these errors were encountered: