Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependency on unicode-segmentation #1003

Closed
shepmaster opened this issue Jul 18, 2017 · 4 comments
Closed

Upgrade dependency on unicode-segmentation #1003

shepmaster opened this issue Jul 18, 2017 · 4 comments

Comments

@shepmaster
Copy link
Contributor

As you noticed, I had to remove clap from the crates on the playground. After trying to update the crates again, it still failed, so I did a bit of digging.

Right now, unicode-segmentation is one of the top-100 downloaded crates, as is clap. The playgrounds logic is to take the newest version of all available crates and resolve them together.

Unfortunately for this case, clap 2.25.0 disallows that version (also, there doesn't appear to be a tag for 2.25.0?).

It's likely that a future version of Cargo will introduce the concept of public/private dependencies. If unicode-segmentation is such, this type of problem will be magically solved. Until then, our hands are tied a bit — we have to prevent one or the other. Right now, clap is the only consumer of unicode-segmentation, so I can probably blacklist unicode-segmentation, but if anyone else starts using it, clap might be the one to lose out 😿

I see the comment and understand why you have to limit the version; I just wanted to let you know the outcome of that.

@mgeisler
Copy link
Contributor

Hi @shepmaster -- I just saw that it was me who introduced the version restriction in dd4c41e.

I saw somewhere that clap is committed to supporting the two previous stable versions of Rust, which these days means Rust 1.17 and later. So perhaps this is easy to resolve by dropping support for the older versions of Rust. @kbknapp should weigh in here, I think.

@shepmaster
Copy link
Contributor Author

shepmaster commented Jul 23, 2017

Perhaps it is! To be clear, as a user of clap, I'm not in need of this change; I just wanted to give the heads up. Of course, if it's upgraded, my life as playground maintainer would be made easier 😈

@kbknapp
Copy link
Member

kbknapp commented Jul 29, 2017

I'm good with moving the minimum version of Rust to 1.13, so long as we also bump the minor. Yes, 1.17 is technically as far back as I'm guaranteed to support, but in practice I've been FAR more conservative.

As I've been saying for nearly 6 months now, I was hoping to get 3.x out the door and wait until then tobump the minimum required version of Rust. Buuut, life has been getting in t he way of that. So I'm fine upgrading to Rust 1.13.

@kbknapp
Copy link
Member

kbknapp commented Jul 29, 2017

Closed with v2.26.0

@kbknapp kbknapp closed this as completed Jul 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants