diff --git a/rclcpp/include/rclcpp/experimental/buffers/intra_process_buffer.hpp b/rclcpp/include/rclcpp/experimental/buffers/intra_process_buffer.hpp index aef38a028d..c2e747e774 100644 --- a/rclcpp/include/rclcpp/experimental/buffers/intra_process_buffer.hpp +++ b/rclcpp/include/rclcpp/experimental/buffers/intra_process_buffer.hpp @@ -16,6 +16,7 @@ #define RCLCPP__EXPERIMENTAL__BUFFERS__INTRA_PROCESS_BUFFER_HPP_ #include +#include #include #include diff --git a/rclcpp/include/rclcpp/experimental/buffers/ring_buffer_implementation.hpp b/rclcpp/include/rclcpp/experimental/buffers/ring_buffer_implementation.hpp index ad01946193..c01240b429 100644 --- a/rclcpp/include/rclcpp/experimental/buffers/ring_buffer_implementation.hpp +++ b/rclcpp/include/rclcpp/experimental/buffers/ring_buffer_implementation.hpp @@ -15,10 +15,6 @@ #ifndef RCLCPP__EXPERIMENTAL__BUFFERS__RING_BUFFER_IMPLEMENTATION_HPP_ #define RCLCPP__EXPERIMENTAL__BUFFERS__RING_BUFFER_IMPLEMENTATION_HPP_ -#include -#include -#include -#include #include #include #include diff --git a/rclcpp/include/rclcpp/experimental/create_intra_process_buffer.hpp b/rclcpp/include/rclcpp/experimental/create_intra_process_buffer.hpp index 1d232d14fe..4d7668b964 100644 --- a/rclcpp/include/rclcpp/experimental/create_intra_process_buffer.hpp +++ b/rclcpp/include/rclcpp/experimental/create_intra_process_buffer.hpp @@ -16,11 +16,9 @@ #define RCLCPP__EXPERIMENTAL__CREATE_INTRA_PROCESS_BUFFER_HPP_ #include -#include +#include #include -#include "rcl/subscription.h" - #include "rclcpp/experimental/buffers/intra_process_buffer.hpp" #include "rclcpp/experimental/buffers/ring_buffer_implementation.hpp" #include "rclcpp/intra_process_buffer_type.hpp" diff --git a/rclcpp/include/rclcpp/experimental/executable_list.hpp b/rclcpp/include/rclcpp/experimental/executable_list.hpp index e1c70db3de..887dd6cd8f 100644 --- a/rclcpp/include/rclcpp/experimental/executable_list.hpp +++ b/rclcpp/include/rclcpp/experimental/executable_list.hpp @@ -15,7 +15,6 @@ #ifndef RCLCPP__EXPERIMENTAL__EXECUTABLE_LIST_HPP_ #define RCLCPP__EXPERIMENTAL__EXECUTABLE_LIST_HPP_ -#include #include #include "rclcpp/client.hpp" diff --git a/rclcpp/include/rclcpp/experimental/intra_process_manager.hpp b/rclcpp/include/rclcpp/experimental/intra_process_manager.hpp index 5cc0b83db7..469dc711f8 100644 --- a/rclcpp/include/rclcpp/experimental/intra_process_manager.hpp +++ b/rclcpp/include/rclcpp/experimental/intra_process_manager.hpp @@ -19,13 +19,9 @@ #include -#include -#include -#include -#include -#include +#include #include -#include +#include #include #include #include diff --git a/rclcpp/include/rclcpp/experimental/subscription_intra_process.hpp b/rclcpp/include/rclcpp/experimental/subscription_intra_process.hpp index 679aff1644..c6beebbc97 100644 --- a/rclcpp/include/rclcpp/experimental/subscription_intra_process.hpp +++ b/rclcpp/include/rclcpp/experimental/subscription_intra_process.hpp @@ -15,25 +15,22 @@ #ifndef RCLCPP__EXPERIMENTAL__SUBSCRIPTION_INTRA_PROCESS_HPP_ #define RCLCPP__EXPERIMENTAL__SUBSCRIPTION_INTRA_PROCESS_HPP_ -#include +#include -#include -#include #include #include #include +#include #include -#include "rcl/error_handling.h" +#include "rcl/types.h" #include "rclcpp/any_subscription_callback.hpp" +#include "rclcpp/context.hpp" #include "rclcpp/experimental/buffers/intra_process_buffer.hpp" -#include "rclcpp/experimental/create_intra_process_buffer.hpp" -#include "rclcpp/experimental/subscription_intra_process_base.hpp" #include "rclcpp/experimental/subscription_intra_process_buffer.hpp" #include "rclcpp/qos.hpp" #include "rclcpp/type_support_decl.hpp" -#include "rclcpp/waitable.hpp" #include "tracetools/tracetools.h" namespace rclcpp diff --git a/rclcpp/include/rclcpp/experimental/subscription_intra_process_base.hpp b/rclcpp/include/rclcpp/experimental/subscription_intra_process_base.hpp index ba575c763c..c97dbadbc7 100644 --- a/rclcpp/include/rclcpp/experimental/subscription_intra_process_base.hpp +++ b/rclcpp/include/rclcpp/experimental/subscription_intra_process_base.hpp @@ -15,19 +15,14 @@ #ifndef RCLCPP__EXPERIMENTAL__SUBSCRIPTION_INTRA_PROCESS_BASE_HPP_ #define RCLCPP__EXPERIMENTAL__SUBSCRIPTION_INTRA_PROCESS_BASE_HPP_ -#include - -#include #include #include #include -#include -#include "rcl/error_handling.h" +#include "rcl/wait.h" #include "rclcpp/guard_condition.hpp" #include "rclcpp/qos.hpp" -#include "rclcpp/type_support_decl.hpp" #include "rclcpp/waitable.hpp" namespace rclcpp diff --git a/rclcpp/include/rclcpp/experimental/subscription_intra_process_buffer.hpp b/rclcpp/include/rclcpp/experimental/subscription_intra_process_buffer.hpp index 2874c321b8..cb7a9c32b8 100644 --- a/rclcpp/include/rclcpp/experimental/subscription_intra_process_buffer.hpp +++ b/rclcpp/include/rclcpp/experimental/subscription_intra_process_buffer.hpp @@ -15,27 +15,22 @@ #ifndef RCLCPP__EXPERIMENTAL__SUBSCRIPTION_INTRA_PROCESS_BUFFER_HPP_ #define RCLCPP__EXPERIMENTAL__SUBSCRIPTION_INTRA_PROCESS_BUFFER_HPP_ -#include - -#include -#include //TODO remove -#include +#include // TODO remove #include #include #include #include #include "rcl/error_handling.h" +#include "rcl/guard_condition.h" +#include "rcl/wait.h" -#include "rclcpp/any_subscription_callback.hpp" #include "rclcpp/experimental/buffers/intra_process_buffer.hpp" #include "rclcpp/experimental/create_intra_process_buffer.hpp" #include "rclcpp/experimental/subscription_intra_process_base.hpp" #include "rclcpp/experimental/ros_message_intra_process_buffer.hpp" #include "rclcpp/qos.hpp" #include "rclcpp/type_support_decl.hpp" -#include "rclcpp/waitable.hpp" -#include "tracetools/tracetools.h" namespace rclcpp { diff --git a/rclcpp/include/rclcpp/node_interfaces/node_topics.hpp b/rclcpp/include/rclcpp/node_interfaces/node_topics.hpp index b4d8c5b2f6..33a87732d6 100644 --- a/rclcpp/include/rclcpp/node_interfaces/node_topics.hpp +++ b/rclcpp/include/rclcpp/node_interfaces/node_topics.hpp @@ -20,12 +20,16 @@ #include "rcl/publisher.h" #include "rcl/subscription.h" +#include "rclcpp/callback_group.hpp" #include "rclcpp/macros.hpp" #include "rclcpp/node_interfaces/node_base_interface.hpp" #include "rclcpp/node_interfaces/node_timers_interface.hpp" #include "rclcpp/node_interfaces/node_topics_interface.hpp" -#include "rclcpp/publisher.hpp" +#include "rclcpp/publisher_base.hpp" #include "rclcpp/publisher_factory.hpp" +#include "rclcpp/qos.hpp" +#include "rclcpp/subscription_base.hpp" +#include "rclcpp/subscription_factory.hpp" #include "rclcpp/visibility_control.hpp" namespace rclcpp diff --git a/rclcpp/include/rclcpp/publisher.hpp b/rclcpp/include/rclcpp/publisher.hpp index 73d76e46dc..f2dbba2846 100644 --- a/rclcpp/include/rclcpp/publisher.hpp +++ b/rclcpp/include/rclcpp/publisher.hpp @@ -20,12 +20,14 @@ #include #include #include +#include #include #include "rcl/error_handling.h" #include "rcl/publisher.h" #include "rmw/error_handling.h" #include "rmw/rmw.h" +#include "rosidl_runtime_cpp/traits.hpp" #include "rclcpp/allocator/allocator_common.hpp" #include "rclcpp/allocator/allocator_deleter.hpp" diff --git a/rclcpp/include/rclcpp/subscription_factory.hpp b/rclcpp/include/rclcpp/subscription_factory.hpp index 4da6c236bf..a1727eab5a 100644 --- a/rclcpp/include/rclcpp/subscription_factory.hpp +++ b/rclcpp/include/rclcpp/subscription_factory.hpp @@ -26,14 +26,13 @@ #include "rclcpp/any_subscription_callback.hpp" #include "rclcpp/get_message_type_support_handle.hpp" -#include "rclcpp/intra_process_buffer_type.hpp" #include "rclcpp/node_interfaces/node_base_interface.hpp" #include "rclcpp/qos.hpp" #include "rclcpp/subscription.hpp" #include "rclcpp/subscription_options.hpp" #include "rclcpp/subscription_traits.hpp" -#include "rclcpp/visibility_control.hpp" #include "rclcpp/topic_statistics/subscription_topic_statistics.hpp" +#include "rclcpp/visibility_control.hpp" namespace rclcpp { diff --git a/rclcpp/src/rclcpp/node_interfaces/node_topics.cpp b/rclcpp/src/rclcpp/node_interfaces/node_topics.cpp index fa188a2f9a..284795ef6e 100644 --- a/rclcpp/src/rclcpp/node_interfaces/node_topics.cpp +++ b/rclcpp/src/rclcpp/node_interfaces/node_topics.cpp @@ -14,9 +14,18 @@ #include "rclcpp/node_interfaces/node_topics.hpp" +#include #include +#include "rclcpp/callback_group.hpp" #include "rclcpp/exceptions.hpp" +#include "rclcpp/node_interfaces/node_base_interface.hpp" +#include "rclcpp/node_interfaces/node_timers_interface.hpp" +#include "rclcpp/publisher_base.hpp" +#include "rclcpp/publisher_factory.hpp" +#include "rclcpp/subscription_base.hpp" +#include "rclcpp/subscription_factory.hpp" +#include "rclcpp/qos.hpp" using rclcpp::exceptions::throw_from_rcl_error;