Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probable bug in clsparseScsrmm() with cldenseMatrix #208

Open
UsherWang opened this issue Apr 28, 2017 · 2 comments
Open

Probable bug in clsparseScsrmm() with cldenseMatrix #208

UsherWang opened this issue Apr 28, 2017 · 2 comments

Comments

@UsherWang
Copy link

Hi there,

I was testing clsparse on Nvidia gtx 690 because I want to rewrite my cuda code into opencl for it support much more platforms. While I was testing clsparseScsrmm(), the sparse-dense matrix multiply routine, I found that no matter what major the dense matrix is set(cldenseMatrix mat; mat.major = rowMajor; or mat.major = columnMajor; ), clsparseScsrmm() always reads and writes data in row major. For more specific situation, when I set major to rowMajor I get correct result, otherwise I get wrong result. Then I tested the columnMajor and find it reads and writes data in rowMajor.

Thank you guys very much for helping me with this.

Usher

@UsherWang UsherWang changed the title Probable bug in cldenseMatrix with clsparseScsrmm() Probable bug in clsparseScsrmm() with cldenseMatrix Apr 28, 2017
@tingxingdong
Copy link

I agree. The column major is widely used and the in-fact standard. rowMajor is not.
column major should be supported in the first place.

@zhouhuanxiang
Copy link

zhouhuanxiang commented Apr 24, 2018

Same problem.
The reason is that the csrmm() function in clsparse-csrmm.hpp simply discards memory layout infomation. And it seems that authors won't fix the problem. Disappointed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants