CreateFile call not working with wstring on Windows

[mabraham]

At

clFFT/src/library/fft_binary_lookup.cpp

Line 123 in c59712e

HANDLE handle = CreateFile(tmp.c_str(),

the CreateFile function is used with a wide string. The GROMACS project bundles a recent version of clFFT that has the same implementation. For one user of GROMACS, it did not work - see https://mailman-1.sys.kth.se/pipermail/gromacs.org_gmx-users/2019-January/123689.html.

I can see that CreateFileA https://docs.microsoft.com/en-us/windows/desktop/api/FileAPI/nf-fileapi-createfilea requires a non-wide char pointer, and the CreateFileW version is probably supposed to be used. I don't know how CreateFile works, but I assume that it must be something that ought to resolve to CreateFileA or CreateFileW according to the type of the first parameter, but it didn't work in this case.

Given that the non-Windows code uses a normal non-wide char, perhaps Windows should also do that?

[mabraham]

I see at https://github.com/clMathLibraries/clFFT/wiki/Build#supported-compilers that only VS 2010 is supported, which may be related here.

I will disable GROMACS support for OpenCL on Windows accordingly.

[VincentSC]

VS2010? Indeed looks like AMD's open source OpenCL libraries need some work. :/