More rusty and support shanghai fork #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckoopmann
requested changes
Oct 24, 2023
|
|
||
| fn try_from(x: u8) -> Result<Self, Self::Error> { | ||
| match x { | ||
| x if x == Opcode::STOP as u8 => Ok(Opcode::STOP), |
There was a problem hiding this comment.
This seems more verbose than the original mapping. I have a hunch there should be a more concise way to do this . Like using match to check wether the value matches any of the enum values in one line instead of 1 line for each enum variant. what do you think ?
| SELFDESTRUCT = 255, | ||
| } | ||
|
|
||
| impl TryFrom<u8> for Opcode { |
There was a problem hiding this comment.
Generally good idea to implement tryFrom 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.
TryFrom