Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Writer doesn't load in the review comment textarea #345

Closed
Dumluregn opened this issue Aug 5, 2022 · 2 comments Β· Fixed by #349
Closed

GH Writer doesn't load in the review comment textarea #345

Dumluregn opened this issue Aug 5, 2022 · 2 comments Β· Fixed by #349
Assignees
Labels
bug Something isn't working squad:features
Milestone

Comments

@Dumluregn
Copy link
Contributor

πŸ“ Provide detailed reproduction steps (if any)

  1. Open any PR.
  2. Go to Files changed tab.
  3. Click Review changes button.

βœ”οΈ Expected result

GH Writer should be loaded in the popping editable.

❌ Actual result

No GH Writer:

❓ Possible solution

AFAICS the selector assigned for the ReviewEditor class (div.pull-request-review-menu > form) is outdated - it doesn't match any element on the site. Probably adjusting it should be enough to solve the issue.

It could be a good idea to ensure that all the other editor types still have proper selectors (probably so as do similar issues are reported, but still).

πŸ“ƒ Other details

  • Browser: any
  • OS: any

If you'd like to see this fixed sooner, add a πŸ‘ reaction to this post.

@Dumluregn Dumluregn added the bug Something isn't working label Aug 5, 2022
@mateuszzagorski mateuszzagorski self-assigned this Aug 8, 2022
@mateuszzagorski
Copy link
Contributor

mateuszzagorski commented Aug 9, 2022

Updating the selector does seem to resolve the issue for ReviewEditor not being loaded as per your suggestion.

We should consider applying some tweaks to the styling of it, because now after it's loaded it looks like this:

Normal view:

Markdown view:

Edit: This is happening only on smaller screen sizes.

@Dumluregn
Copy link
Contributor Author

Since you've said that .pull-request-review-menu class is currently added by Writer, I guess there may also be some custom CSS attached? Then it should be enough to just change the selectors there too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working squad:features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants