Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change editor.model.data to output JSON #179

Closed
fredck opened this issue May 12, 2020 · 0 comments · Fixed by #182
Closed

Change editor.model.data to output JSON #179

fredck opened this issue May 12, 2020 · 0 comments · Fixed by #182
Labels
enhancement A possible enhancement of an existing feature.

Comments

@fredck
Copy link
Contributor

fredck commented May 12, 2020

A resent research, published at ckeditor/ckeditor5#5812 (comment), shows that JSON could be a better format for the data produced by editor.model.data.

Changing this would bring little real benefit to GitHub Writer, but we may consider doing so, for the sake of having a more quality implementation. Also, others may want to use the plugin in other projects and it's better to spread the best option right from the start.
@fredck fredck added the enhancement A possible enhancement of an existing feature. label May 12, 2020
@fredck fredck mentioned this issue May 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A possible enhancement of an existing feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switched editor.model.data to JSON ckeditor/github-writer
1 participant
@fredck