Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide toolbars when starts dragging the content #9604

Merged
merged 6 commits into from
May 4, 2021

Conversation

pomek
Copy link
Member

@pomek pomek commented Apr 30, 2021

Suggested merge commit message (convention)

Fix (clipboard): Hide all toolbars when the user starts dragging the widget and show them when the drag ends. Closes #9566.


Nagranie.z.ekranu.2021-04-30.o.11.13.43.mov

@FilipTokarski
Copy link
Member

Works fine now👌

@niegowski
Copy link
Contributor

There is a problem in Chrome and Firefox that the dragend event is not fired if the original node got removed from the document while dragging. This works ok for widgets because they are not modified, but if you drag out some text content to some other editable area the event is not fired ever and the toolbars stay disabled until you start dragging some widget again:

@pomek
Copy link
Member Author

pomek commented May 1, 2021

It does not sound good. However, it's easy to fix - let's disable the WidgetToolbarRepository plugin only if the widget element is dragged.

@pomek
Copy link
Member Author

pomek commented May 1, 2021

Should be good now.

@niegowski
Copy link
Contributor

I feel like it should be the other way around. The DragDrop plugin should disable the widget toolbar.

@pomek
Copy link
Member Author

pomek commented May 2, 2021

Even fewer changes.

@niegowski niegowski merged commit f3f1020 into i/2052-inline-images May 4, 2021
@niegowski niegowski deleted the i/9566 branch May 4, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants