#8871: Integrate inline images with the link feature #9438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge upcast does not collide with the linke inline image upcast.
…port inline images.
…n with LinkImage.
…n with LinkImage works correctly.
…th inline images.
…ommands more generic and less related to images.
…fter unlinking an inline image.
niegowski
requested changes
Apr 16, 2021
niegowski
requested changes
Apr 19, 2021
|
There are plenty of conflicts now since #9459 was merged and I'm addressing them. |
niegowski
reviewed
Apr 20, 2021
Co-authored-by: Kuba Niegowski <[email protected]>
This was referenced Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other (link): Integrated the link feature with inline images. Closes #8871. Closes #9017. Closes #9167.
Other (image): Turned the image utils module into an editor plugin to allow sharing utils outside the package. Code refactoring (see #8871).
Additional information
BREAKING CHANGE (image): The image utils module (
@ckeditor/ckeditor5-image/src/image/utils.js) has turned into theImageUtilsplugin. The helpers are still accessible viaeditor.plugins.get( 'ImageUtils' )namespace, for instance,editor.plugins.get( 'ImageUtils' ).isImage( ... ).BREAKING CHANGE (image): The linked image indicator (icon) rendered as a
<span>with the.ck-link-image_iconCSS class has been removed. To alter the look of the indicator (including the icon), please usefigure.image > a::after(for linked block images) anda span.image-inline::after(for linked inline images) CSS selectors instead.BREAKING CHANGE (image): The API of the
insertImage()helper has changed, please make sure to update your integrations.BREAKING CHANGE (image): The
isImageWidget()helper is no longer exposed by theImageplugin. Use theImageUtilsplugin to access this helper instead.BREAKING CHANGE (image): The API of common image converters has changed. Please refer to the documentation to learn more.
BREAKING CHANGE (image): The API of various image caption utils has changed. Please refer to the documentation to learn more.