Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Firefox] Selecting widget together with page break results in error #8548

Closed
FilipTokarski opened this issue Nov 30, 2020 · 2 comments
Closed
Labels
browser:firefox package:page-break package:widget resolution:expired This issue was closed due to lack of feedback. status:stale type:bug This issue reports a buggy (incorrect) behavior.

Comments

@FilipTokarski
Copy link
Member

📝 Provide detailed reproduction steps (if any)

  1. In Firefox go to https://ckeditor.com/docs/ckeditor5/latest/features/page-break.html
  2. Add image / media embed / html embed right after page break
  3. Make selection spanning content - page break - widget

✔️ Expected result

Selection is created, no errors

❌ Actual result

Editor crashes:

Uncaught CKEditorError: model-nodelist-offset-out-of-bounds {"offset":10,"nodeList":[]}
Read more: https://ckeditor.com/docs/ckeditor5/latest/framework/guides/…t/error-codes.html#error-model-nodelist-offset-out-of-bounds
    s https://ckeditor.com/docs/ckeditor5/latest/snippets/features/page-break/snippet.js:4
    offsetToIndex https://ckeditor.com/docs/ckeditor5/latest/snippets/features/page-break/snippet.js:4
    offsetToIndex https://ckeditor.com/docs/ckeditor5/latest/snippets/features/page-break/snippet.js:4
    a https://ckeditor.com/docs/ckeditor5/latest/snippets/features/page-break/snippet.js:4
    get textNode https://ckeditor.com/docs/ckeditor5/latest/snippets/features/page-break/snippet.js:4
    qe https://ckeditor.com/docs/ckeditor5/latest/snippets/features/page-break/snippet.js:4
    _validateSelectionRange https://ckeditor.com/docs/ckeditor5/latest/snippets/features/page-break/snippet.js:4
    m https://ckeditor.com/docs/ckeditor5/latest/snippets/features/page-break/snippet.js:4
    fire https://ckeditor.com/docs/ckeditor5/latest/snippets/features/page-break/snippet.js:4
    _setRanges https://ckeditor.com/docs/ckeditor5/latest/snippets/features/page-break/snippet.js:4
    setTo https://ckeditor.com/docs/ckeditor5/latest/snippets/features/page-break/snippet.js:4
    setTo https://ckeditor.com/docs/ckeditor5/latest/snippets/features/page-break/snippet.js:4
    _setTo https://ckeditor.com/docs/ckeditor5/latest/snippets/features/page-break/snippet.js:4
    setSelection https://ckeditor.com/docs/ckeditor5/latest/snippets/features/page-break/snippet.js:4
    Ft https://ckeditor.com/docs/ckeditor5/latest/snippets/features/page-break/snippet.js:4
    _runPendingChanges https://ckeditor.com/docs/ckeditor5/latest/snippets/features/page-break/snippet.js:4
    change https://ckeditor.com/docs/ckeditor5/latest/snippets/features/page-break/snippet.js:4
    Ft https://ckeditor.com/docs/ckeditor5/latest/snippets/features/page-break/snippet.js:4
    fire https://ckeditor.com/docs/ckeditor5/latest/snippets/features/page-break/snippet.js:4
    _handleSelectionChange https://ckeditor.com/docs/ckeditor5/latest/snippets/features/page-break/snippet.js:4
    observe https://ckeditor.com/docs/ckeditor5/latest/snippets/features/page-break/snippet.js:4
    fire https://ckeditor.com/docs/ckeditor5/latest/snippets/features/page-break/snippet.js:4
    n https://ckeditor.com/docs/ckeditor5/latest/snippets/features/page-break/snippet.js:4
    attach https://ckeditor.com/docs/ckeditor5/latest/snippets/features/page-break/snippet.js:4
    listenTo https://ckeditor.com/docs/ckeditor5/latest/snippets/features/page-break/snippet.js:4
    observe https://ckeditor.com/docs/ckeditor5/latest/snippets/features/page-break/snippet.js:4
    attachDomRoot https://ckeditor.com/docs/ckeditor5/latest/snippets/features/page-break/snippet.js:4
    init https://ckeditor.com/docs/ckeditor5/latest/snippets/features/page-break/snippet.js:4
    create https://ckeditor.com/docs/ckeditor5/latest/snippets/features/page-break/snippet.js:4
    promise callback*create/< https://ckeditor.com/docs/ckeditor5/latest/snippets/features/page-break/snippet.js:4
    create https://ckeditor.com/docs/ckeditor5/latest/snippets/features/page-break/snippet.js:4
    <anonymous> https://ckeditor.com/docs/ckeditor5/latest/snippets/features/page-break/snippet.js:4
    n https://ckeditor.com/docs/ckeditor5/latest/snippets/features/page-break/snippet.js:4
    <anonymous> https://ckeditor.com/docs/ckeditor5/latest/snippets/features/page-break/snippet.js:4
    <anonymous> https://ckeditor.com/docs/ckeditor5/latest/snippets/features/page-break/snippet.js:4
snippet.js:4:1264

0_page-break1

📃 Other details

  • Browser: Firefox
  • CKEditor version: happens since 19.1.1, before that the selection is broken and there's no way of reproducing this
  • Looks similar to Selecting an Image from bottom to top throws exceptions #7892 but has different error message
  • You can reproduce this going from top to bottom or from bottom up, but always in this order -> content - page break - widget
  • Happens also on latest master on manual tests
  • Happens with image or media embed or html embed + page break
  • After the crash, you cannot do anything in the editor

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@FilipTokarski FilipTokarski added type:bug This issue reports a buggy (incorrect) behavior. package:widget browser:firefox package:page-break labels Nov 30, 2020
@mlewand mlewand added this to the nice-to-have milestone Dec 7, 2020
@pomek pomek removed this from the nice-to-have milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 13, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser:firefox package:page-break package:widget resolution:expired This issue was closed due to lack of feedback. status:stale type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

4 participants