Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when click-drag selecting up on text with Horizontal line in FireFox #7949

Closed
mvhdi opened this issue Aug 26, 2020 · 2 comments
Closed
Labels
browser:firefox package:horizontal-rule resolution:duplicate This issue is a duplicate of another issue and was merged into it. type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.

Comments

@mvhdi
Copy link

mvhdi commented Aug 26, 2020

📝 Provide detailed reproduction steps (if any)

  1. Open the Collaborative Editor in classic mode, with the horizontal line plugin, in Firefox.
  2. Click below a horizontal line
  3. Drag select upward getting the horizontal line and text above it.

✔️ Expected result

We should be able to drag up toward a horizontal line and select the horizontal line and the text above it, without any errors or buggy movement that takes us to the top of the page.

What is the expected result of the above steps?

❌ Actual result

  1. Error is thrown: https://ckeditor.com/docs/ckeditor5/latest/framework/guides/support/error-codes.html#error-model-selection-range-intersects
  2. Buggy movement Editor moves up taking us to the top of the page.

Example: https://ckeditor.com/docs/ckeditor5/latest/features/horizontal-line.html

ezgif com-video-to-gif

What is the actual result of the above steps?

📃 Other details

  • Browser: FireFox
  • OS: macos
  • CKEditor : classic, collaborative editor
  • Horizontal line: @ckeditor/ckeditor5-horizontal-line": "^21.0.0"
  • Installed CKEditor plugins: horizontal Line plugin

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@mvhdi mvhdi added the type:bug This issue reports a buggy (incorrect) behavior. label Aug 26, 2020
@mvhdi mvhdi changed the title click-drag selecting up on text with Horizontal line FireFox Error when click-drag selecting up on text with Horizontal line FireFox Aug 26, 2020
@mvhdi mvhdi changed the title Error when click-drag selecting up on text with Horizontal line FireFox Error when click-drag selecting up on text with Horizontal line in FireFox Aug 26, 2020
@FilipTokarski
Copy link
Member

Hi, thanks for the report. I confirm this bug, it's a regression introduced in version 20.0.0.

Bisection shows this commit: 824d731

Error message:

Uncaught CKEditorError: model-selection-range-intersects: Trying to add a range that intersects with another range in the selection. Read more: https://ckeditor.com/docs/ckeditor5/latest/framework/guides/…port/error-codes.html#error-model-selection-range-intersects
 {"addedRange":{"start":{"root":"main","path":[8],"stickiness":"toNext"},"end":{"root":"main","path":[9,2],"stickiness":"toPrevious"}},"intersectingRange":{"start":{"root":"main","path":[8,0],"stickiness":"toNone"},"end":{"root":"main","path":[8,0],"stickiness":"toNone"}}}
    i ckeditorerror.js:66
    _checkRange selection.js:758
    _prepareRange documentselection.js:820
    _pushRange documentselection.js:805
    _setRanges selection.js:474
    setTo selection.js:405
    setTo documentselection.js:734
    _setTo documentselection.js:421
    setSelection writer.js:1189
    Ye selection-post-fixer.js:102
    Ye selection-post-fixer.js:65
    _callPostFixers document.js:412
    _handleChangeBlock document.js:311
    _runPendingChanges model.js:826
    change model.js:170
    Rt upcasthelpers.js:412
    fire emittermixin.js:209
    _handleSelectionChange selectionobserver.js:183
    observe selectionobserver.js:104
    fire emittermixin.js:209
    n emittermixin.js:235
    attach emittermixin.js:193
    listenTo emittermixin.js:59
    observe selectionobserver.js:103
    attachDomRoot view.js:286
    init classiceditorui.js:105
    create classiceditor.js:199
    promise callback*create/< classiceditor.js:199
    create classiceditor.js:194
    <anonymous> horizontal-line.js:17

@FilipTokarski FilipTokarski added browser:firefox package:horizontal-rule type:regression This issue reports a bug that was not present in the previous releases. labels Aug 27, 2020
@FilipTokarski
Copy link
Member

It seems to be the same issue as in #7892. The same browser, steps and bisection result. I'll close this one for now as a duplicate and let's track it there.

@FilipTokarski FilipTokarski added the resolution:duplicate This issue is a duplicate of another issue and was merged into it. label Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser:firefox package:horizontal-rule resolution:duplicate This issue is a duplicate of another issue and was merged into it. type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.
Projects
None yet
Development

No branches or pull requests

2 participants