Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images in numbered lists trigger number reset #7397

Closed
HDinger opened this issue Jun 8, 2020 · 3 comments
Closed

Images in numbered lists trigger number reset #7397

HDinger opened this issue Jun 8, 2020 · 3 comments
Labels
resolution:duplicate This issue is a duplicate of another issue and was merged into it. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@HDinger
Copy link

HDinger commented Jun 8, 2020

πŸ“ Provide detailed reproduction steps (if any)

  1. Create a numbered list
  2. Add an image inside the list

image_in_list

βœ”οΈ Expected result

The numbering should be kept when an image is inserted. I expect something like this:
how-it-should-look

❌ Actual result

The numbering is broken by the image. The number below it, starts again from "1" instead of continuing the previous numbering.

πŸ“ƒ Other details


If you'd like to see this fixed sooner, add a πŸ‘ reaction to this post.

@HDinger HDinger added the type:bug This issue reports a buggy (incorrect) behavior. label Jun 8, 2020
@alexishuxley
Copy link

alexishuxley commented Jun 8, 2020

It would be great to get this fixed; including images in numbered lists is essential in writing good documentation with "addressable" steps. E.g.:

  1. Scroll down the page to the share icon, which looks like this:
    image
    and click it.
  2. Select the recipient application.

The above two list items were both done in Github's editor with '1.' and '1.', where it is displayed correctly, but in ckeditor itself it is not displayed correctly, which leads to conversations like:

I got as far as step 1 and then it went wrong.
Err, which step 1? The first step 1 or the second step 1?

@alexishuxley
Copy link

It looks like the same applies to putting code blocks in numbered lists.

@Mgsy
Copy link
Member

Mgsy commented Jun 9, 2020

Hi, thanks for the report. CKEditor 5 doesn't support block elements inside lists, so every time you try to insert a block element to a list item, it will create a new paragraph.Β 

We have an open feature request for inserting more advanced lists (allowing inserting block elements to an item), you can read about it here. Feel free to add πŸ‘ to the first post and join the discussion to bump its popularity.

@Mgsy Mgsy closed this as completed Jun 9, 2020
@Mgsy Mgsy added the resolution:duplicate This issue is a duplicate of another issue and was merged into it. label Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution:duplicate This issue is a duplicate of another issue and was merged into it. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

3 participants