Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table balloon rendered in wrong place after unlinking text in table #6408

Closed
FilipTokarski opened this issue Mar 11, 2020 · 2 comments
Closed
Assignees
Labels
package:table squad:features Issue to be handled by the Features team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@FilipTokarski
Copy link
Member

FilipTokarski commented Mar 11, 2020

📝 Provide detailed reproduction steps (if any)

  1. Open some editor with table and link features
    ( for example it's easy to reproduce on classic-editor-with-real-time-collaboration sample )
  2. Add a link in some cell
  3. Unlink

✔️ Expected result

Text is unlinked, table balloon appears at the top of the table

❌ Actual result

Text is unlinked, table balloon jumps to top-left corner of the window:

table_link_render

📃 Other details

  • It is hard to spot, because most of the times some elements on the page are covering the balloon when it jumps to top-left corner ( this is exactly the case in most of the tests and docs, so sometimes you need to remove html to see it clearly )
  • Browser: any
  • OS: any
  • CKEditor version: Introduced in version 12.2.0
  • Installed CKEditor plugins: Table, Link

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@FilipTokarski FilipTokarski added type:bug This issue reports a buggy (incorrect) behavior. package:table labels Mar 11, 2020
@Reinmar Reinmar added this to the nice-to-have milestone Mar 24, 2020
@mlewand mlewand added the squad:features Issue to be handled by the Features team. label Sep 29, 2021
@mlewand mlewand modified the milestones: nice-to-have, iteration 48 Sep 29, 2021
@mateuszzagorski mateuszzagorski self-assigned this Sep 29, 2021
@FilipTokarski
Copy link
Member Author

Seems like the original issue if fixed now. However I'm not sure if the current behaviour is 100% correct, as after unlinking the table balloon shows up on the unlinked text, instead on the table:

0_tablelink1.mp4

@mateuszzagorski
Copy link
Contributor

@FilipTokarski it seems that it has been already found by @LukaszGudel here:
#10373 (comment)

And as per Dawid's comment regarding resolving this problem:

In this issue it's caused by a mechanism that prevents balloons from jumping around if the context has been changed (for example if you are on a link, but now you jumped out of the link and you see text attributes balloon. It should stay more or less in the same place). Because of this the balloon stays inside the cell, and cell related balloons (for example table cell properties) do not get sticky when scrolling (because it makes no sense for the UI). So we decided it's good enough as is.

it seems that this issue should be closed as the behavior is known and expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:table squad:features Issue to be handled by the Features team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

4 participants