Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Show more items" tooltip placement improvement #5636

Closed
dkonopka opened this issue Oct 21, 2019 · 3 comments · Fixed by #12262
Closed

"Show more items" tooltip placement improvement #5636

dkonopka opened this issue Oct 21, 2019 · 3 comments · Fixed by #12262
Labels
package:theme-lark package:ui squad:features Issue to be handled by the Features team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@dkonopka
Copy link
Contributor

dkonopka commented Oct 21, 2019

📝 Provide detailed reproduction steps (if any)

Thanks to the toolbar grouping feature the editor looks much better on the smaller devices.

But, there is one thing we could improve - tooltip position. In the situation where an editor has small padding or margin there is a possibility of trimmed tooltip content. We know that by default "show more" button will be always the last one, so we could think about this "improvement".

It all boils down to introduce a new class of tooltip component - _sw.

cc @oleq

✔️ Expected result

Screen Shot 2019-10-21 at 10 17 56

What is the expected result of the above steps?

❌ Actual result

Screen Shot 2019-10-21 at 10 19 21


If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@dkonopka dkonopka added type:bug This issue reports a buggy (incorrect) behavior. package:theme-lark labels Oct 21, 2019
@oleq
Copy link
Member

oleq commented Oct 21, 2019

@oleq
Copy link
Member

oleq commented Oct 21, 2019

This should be an easy task:

  • new value (actually 2 values, because in RTL we need to have it mirrored) for the property,
  • simple styles
  • usage in the ToolbarView

@mlewand

@mlewand mlewand added this to the nice-to-have milestone Nov 4, 2019
@pomek pomek removed this from the nice-to-have milestone Feb 21, 2022
@Acrophost
Copy link

Looks like the issue is not reproducible on master anymore.

@CKEditorBot CKEditorBot added this to the iteration 56 milestone Aug 22, 2022
@mlewand mlewand added the squad:features Issue to be handled by the Features team. label Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:theme-lark package:ui squad:features Issue to be handled by the Features team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants