Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The insert image button is enabled in table #5158

Closed
jodator opened this issue Jul 12, 2018 · 1 comment · Fixed by ckeditor/ckeditor5-image#228
Closed

The insert image button is enabled in table #5158

jodator opened this issue Jul 12, 2018 · 1 comment · Fixed by ckeditor/ckeditor5-image#228
Assignees
@jodator
Labels
package:image type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 20

Comments

@jodator
Copy link
Contributor

jodator commented Jul 12, 2018

...but you cannot place an image inside table cell:

selection_016
@oleq oleq self-assigned this Jul 23, 2018
@oleq
Copy link
Member

oleq commented Jul 23, 2018

I wanted to extend the fix to also consider https://github.com/ckeditor/ckeditor5-image/issues/227 but I found out that if I disable the command when another image is selected, it fails to insert multiple images. IMO multi-upload should not rely on that but I didn't thoroughly check how it works either.

@Reinmar Reinmar assigned jodator and unassigned oleq Sep 17, 2018
jodator referenced this issue in ckeditor/ckeditor5-image Sep 28, 2018
@jodator
Merge pull request #228 from ckeditor/t/225
4c1f27f 
Other: The ImageUploadCommand should check whether it can be executed in the selection context. Closes #225. Closes #227. Closes #235.

BREAKING CHANGE: The `options.file` property was renamed to options.files for 'imageUpload' command.
BREAKING CHANGE: The `options.insertAt` property for 'imageUpload' command was removed. The command will now use model's selection.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-image Oct 9, 2019
@mlewand mlewand added this to the iteration 20 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:image labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodator jodator

Labels
package:image type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 20
3 participants
@jodator @oleq @mlewand