-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add confirmation check mark to the image upload animation #5147
Comments
BTW, apparently, there is something wrong with chack mark style, it is too small. It should be of course fixed. |
One comment: I've totally missed that check mark while watching the animation for the first time. Wouldn't be better to put it on the left side of an image? |
IMHO loader bar is appearing from the left to the right and this is the proper direction which the user eyes should follow. cc @oleq |
Maybe the bar also should be a bit bigger as it's also easy to miss - upload is very fast on your gifs. Anyway I think that you guys now the best here, I've just dropping my 2¢ ;) |
Keep in mind that the reason for this tickets is to unify upload UI in Letters and CKE 5, not to redesign it. If, by the way, you can make it better easily it would be great, but I remember we had a really long talk about the thickness of the bar, animation, etc and I don't want to reopen this discussion here. If you find something wrong in the upload UI feel free to report a separate ticket about it. |
Feature: Added upload complete icon. Closes #204.
Feature: Added styles for upload complete icon (see https://github.com/ckeditor/ckeditor5-image/issues/204).
There should be ✅ when the upload finish sucessfully.
This is how it looks now in CKEditor 5:
This is how the animation looks like in Letters (with check mark):
Without it, upload looks incomplete.
The text was updated successfully, but these errors were encountered: