-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Safari] Accent panel opened in a new line cannot be navigated #4312
Comments
After bisecting - breaking commit: Really not sure what happened there, but previous commit works fine (or I missed something obvious) 🤔 |
The commit you found points to... a ticket in which we changed names of UI components and commands. So, we'd need to be very unlucky :D |
I can reproduce this issue on dc6364d. Did you clear the cache when testing it? |
Yeah, that was quite confusing :D But still, even when clearing history in Safari before every test (dev console opened), WFM in all three commits you pointed to. And stops working on commit I pointed to... I do:
|
I have recently updated my macOS to Anyway, as mentioned in issue description it should be solved by #3742. |
I looked into this issue and there is a strange behaviour in Safari while navigating through accent panel. In Chrome characters are rendered when navigating through accent panel in a paragraph as shown below: so it is just text updates and new accented character replaces the old one (as it is already replaced by the browser, And in Safari: So for some strange reason, the which basically breaks the composition. Looking at mutations seems to confirms it, first mutation which replaces |
There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue. |
We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it). |
Extracted from https://github.com/ckeditor/ckeditor5-typing/issues/95.
This issue have been extracted as it is somehow a recurring one. It looks like:
The last non-working version was
v0.10.0
(however it behaved a little different there so the cause was probably different). When tested inv1.0.0-alpha.1
orv1.0.0-alpha.2
it works fine.However, when tested on latest
master
(which will probably become a beta release soon) it looks broken (as shown in above gif). Looks like some changes in the meantime fixed it and then broke it again (will take a look withbisect
later) 🤔Anyway, from what I checked, the current cause is manipulating selection during composition (so we are back to #3742).
The text was updated successfully, but these errors were encountered: