Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Safari] Accent panel opened in a new line cannot be navigated #4312

Closed
f1ames opened this issue Mar 13, 2018 · 10 comments
Closed

[Safari] Accent panel opened in a new line cannot be navigated #4312

f1ames opened this issue Mar 13, 2018 · 10 comments
Labels
browser:safari domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). package:engine resolution:expired This issue was closed due to lack of feedback. status:stale type:bug This issue reports a buggy (incorrect) behavior.

Comments

@f1ames
Copy link
Contributor

f1ames commented Mar 13, 2018

Extracted from https://github.com/ckeditor/ckeditor5-typing/issues/95.

This issue have been extracted as it is somehow a recurring one. It looks like:
safari - mar-13-2018 13-22-26

The last non-working version was v0.10.0 (however it behaved a little different there so the cause was probably different). When tested in v1.0.0-alpha.1 or v1.0.0-alpha.2 it works fine.

However, when tested on latest master (which will probably become a beta release soon) it looks broken (as shown in above gif). Looks like some changes in the meantime fixed it and then broke it again (will take a look with bisect later) 🤔

Anyway, from what I checked, the current cause is manipulating selection during composition (so we are back to #3742).

@f1ames
Copy link
Contributor Author

f1ames commented Mar 13, 2018

After bisecting - breaking commit:
e866e4a -> ckeditor/ckeditor5-font@41e16e0

Really not sure what happened there, but previous commit works fine (or I missed something obvious) 🤔

@Reinmar
Copy link
Member

Reinmar commented Mar 13, 2018

The commit you found points to... a ticket in which we changed names of UI components and commands. So, we'd need to be very unlucky :D

@Reinmar
Copy link
Member

Reinmar commented Mar 13, 2018

I can reproduce this issue on dc6364d. Did you clear the cache when testing it?

@Reinmar
Copy link
Member

Reinmar commented Mar 13, 2018

It WFM on 764a765 and 12cc47a
It does not work on 222669b.

Which.. is very funny, because it's when we introduced CompositionObserver. Perhaps just plugging some listeners to composition events break it?

@f1ames
Copy link
Contributor Author

f1ames commented Mar 13, 2018

The commit you found points to... a ticket in which we changed names of UI components and commands. So, we'd need to be very unlucky :D

Yeah, that was quite confusing :D But still, even when clearing history in Safari before every test (dev console opened), WFM in all three commits you pointed to. And stops working on commit I pointed to...

I do:

git checkout #hash
mgit update
npm run test:manual

@f1ames
Copy link
Contributor Author

f1ames commented Mar 14, 2018

I have recently updated my macOS to High Sierra hoping maybe it will change something, but still it works as I described. Maybe this behaviour is influenced by some Safari/system settings.

Anyway, as mentioned in issue description it should be solved by #3742.

@f1ames
Copy link
Contributor Author

f1ames commented May 30, 2018

I looked into this issue and there is a strange behaviour in Safari while navigating through accent panel. In Chrome characters are rendered when navigating through accent panel in a paragraph as shown below:

image

so it is just text updates and new accented character replaces the old one (as it is already replaced by the browser, renderer doesn't have to render anything - actions: [ "equal" ]).

And in Safari:

image

So for some strange reason, the br element is somehow reinserted. It looks more like Safari is inserting the br element and renderer rerenders it as block filler:

image

which basically breaks the composition. Looking at mutations seems to confirms it, first mutation which replaces a with <br> is fired and then another one which inserts ą (oldChildren is empty).

@f1ames
Copy link
Contributor Author

f1ames commented Jun 5, 2018

Native mutations when long-pressing a in an empty paragraph and then pressing Arrow right 3 times:

Chrome

image

Safari

image

A lot more going on in Safari.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the nice-to-have milestone Oct 9, 2019
@mlewand mlewand added browser:safari module:selection type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
@Reinmar Reinmar added the domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). label Nov 4, 2021
@pomek pomek removed this from the nice-to-have milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 3, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser:safari domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). package:engine resolution:expired This issue was closed due to lack of feedback. status:stale type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

5 participants