Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight is incorrectly converted inside element that has own highlight handling #4167

Closed
scofalik opened this issue Aug 29, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1113
Closed

Highlight is incorrectly converted inside element that has own highlight handling #4167

scofalik opened this issue Aug 29, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1113
Assignees
@scofalik
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 11

Comments

@scofalik
Copy link
Contributor

Because of how marker changes are converted, now it is possible to convert marker to highlight on a text node, even if that text node is inside an element that has own highlight handling and that element is also in a marker range.

The bug occurs when, for example, image has a caption and has a highlight over it. The highlight is dispalyed as a colored border. Then, if there is content added to the image caption, the content gets highlight too (as a changed background) which is a mistake.
@scofalik scofalik self-assigned this Aug 29, 2017
szymonkups referenced this issue in ckeditor/ckeditor5-engine Aug 30, 2017
@szymonkups
Merge pull request #1113 from ckeditor/t/1112
b71adfb 
Fix: Fixed incorrect markers transformations and conversions. Closes #1112. Closes #1080. Closes #1079.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added module:conversion type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
@scofalik scofalik mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scofalik scofalik

Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 11
Development

Successfully merging a pull request may close this issue.

Fixed incorrect markers transformations and conversions ckeditor/ckeditor5-engine
2 participants
@scofalik @mlewand