Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editable needs padding #3385

Closed
oleq opened this issue Dec 12, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-theme-lark#117
Closed

Editable needs padding #3385

oleq opened this issue Dec 12, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-theme-lark#117
Assignees
@oleq

Comments

@oleq
Copy link
Member

oleq commented Dec 12, 2017

A follow-up of https://github.com/ckeditor/ckeditor5-ui/issues/351.

ATM editable implements horizontal padding only. In short, there are situations when the content has no v-spacing at the beginning of editable because of styles of the web page. The theme should anticipate such situation and help developers out.
@oleq oleq self-assigned this Dec 12, 2017
Reinmar referenced this issue in ckeditor/ckeditor5-theme-lark Feb 2, 2018
@Reinmar
Merge pull request #117 from ckeditor/t/116
d717139 
Fix: First child of editable should always have a top margin to make sure the content is separated. Closes #116. Closes ckeditor/ckeditor5-ui#351.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-theme-lark Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
@oleq oleq mentioned this issue Feb 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

t/116: First child of editable should always have top margin ckeditor/ckeditor5-theme-lark
1 participant
@oleq