Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IME][Chrome] Using bold after opening macOS accent panel and choosing accent throws an error #3116

Closed
f1ames opened this issue May 30, 2018 · 4 comments
Labels
browser:chrome domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). package:typing resolution:expired This issue was closed due to lack of feedback. status:stale type:bug This issue reports a buggy (incorrect) behavior.

Comments

@f1ames
Copy link
Contributor

f1ames commented May 30, 2018

Is this a bug report or feature request? (choose one)

🐞 Bug report

💻 Version of CKEditor

CKEditor 5 (v10.0.1)

📋 Steps to reproduce

Extracted from ckeditor/ckeditor5-engine#861 (see ckeditor/ckeditor5-engine#861 (comment)).

  1. Go to https://ckeditor5.github.io.
  2. Use simple content like <p>Foo Bar</p>.
  3. Place selection inside editor and long-press a (so the macOS accent panel is opened).
  4. Click Bold button on a toolbar (Ctrl + b doesn't work here).
  5. Choose accent from accent panel.

✅ Expected result

Bolded accent is inserted, no error thrown.

❎ Actual result

Bolded accent is inserted, error is thrown.

image

📃 Other details that might be useful

Happens only in Chrome (66.0.3359.181 (Official Build) (64-bit)). On Safari and Firefox clicking Bold button closes accent panel.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-typing Oct 9, 2019
@mlewand mlewand added this to the backlog milestone Oct 9, 2019
@mlewand mlewand added browser:chrome status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:typing labels Oct 9, 2019
@Reinmar Reinmar added the domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). label Nov 18, 2019
@FilipTokarski
Copy link
Member

I just checked it with Chrome 80.0.3987.132 on demo page and manual article test on latest master. This issue still occurs but with a slight difference - expected result works fine, you can insert a bolded accent character. But when you then click Bold on the toolbar to turn it off, the error is thrown:

ckeditorerror.js:66 Uncaught CKEditorError: view-renderer-filler-was-lost: The inline filler node was lost. Read more: https://ckeditor.com/docs/ckeditor5/latest/framework/guides/support/error-codes.html#error-view-renderer-filler-was-lost

    at Renderer._removeInlineFiller (http://localhost:8125/ckeditor5/tests/manual/article.js:77853:10)
    at Renderer.render (http://localhost:8125/ckeditor5/tests/manual/article.js:77646:9)
    at View._render (http://localhost:8125/ckeditor5/tests/manual/article.js:82119:18)
    at View.<anonymous> (http://localhost:8125/ckeditor5/tests/manual/article.js:81624:9)
    at View.fire (http://localhost:8125/ckeditor5/tests/manual/article.js:115595:30)
    at View.change (http://localhost:8125/ckeditor5/tests/manual/article.js:81916:10)
    at View._disableRendering (http://localhost:8125/ckeditor5/tests/manual/article.js:82106:9)
    at Model.EditingController.listenTo.priority (http://localhost:8125/ckeditor5/tests/manual/article.js:40512:14)
    at Model.fire (http://localhost:8125/ckeditor5/tests/manual/article.js:115595:30)
    at Model._runPendingChanges (http://localhost:8125/ckeditor5/tests/manual/article.js:52544:8)

@LukaszGudel
Copy link
Contributor

It is possible to also get this error in other browsers (Safari and Firefox), but default UI behavior is not allowing this. Hacky steps to reproduce in other browsers:

  1. Use console to execute: setTimeout(() => editor.commands.execute('bold',true),4000)
  2. Place caret inside the editor
  3. Hold a to open accent window and then wait for Bold button to activate
  4. Choose any character
  5. Click Bold button in the toolbar

@pomek pomek removed this from the backlog milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 2, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser:chrome domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). package:typing resolution:expired This issue was closed due to lack of feedback. status:stale type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

7 participants