Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink running tests for all browsers in each browser #2523

Closed
f1ames opened this issue Nov 5, 2018 · 2 comments
Closed

Rethink running tests for all browsers in each browser #2523

f1ames opened this issue Nov 5, 2018 · 2 comments
Labels
package:paste-from-office resolution:expired This issue was closed due to lack of feedback. status:discussion status:stale type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@f1ames
Copy link
Contributor

f1ames commented Nov 5, 2018

Some time ago we have concluded that it will be good to run tests for all browsers in each browser (see #2481 and #2480). This allows to check if anything fails just by running tests in one browser. And since most of the things happening are detached from the DOM and use native API rarely it makes sense as browser environment does not affect those tests so much.

However, recently I have encountered a case were same input data, generates same normalization data but different model data in Chrome/Firefox vs Edge. Since test utils assumed that all tests are run in each browser, it required some not-good-looking tests skipping (see skip option):

generateTests( {
	input: 'image',
	type: 'integration',
	browsers: [ 'chrome', 'firefox', 'edge' ],
	editorConfig: {
		plugins: [ Clipboard, Paragraph, Image, Table, PasteFromOffice ]
	},
	skip: {
		chrome: ( env.isEdge ? [ 'adjacentGroups' ] : [] ),
		firefox: ( env.isEdge ? [ 'adjacentGroups' ] : [] ),
		edge: ( env.isEdge ? [] : [ 'adjacentGroups' ] )
	}
} );

Of course it could be written in a different ways to be more readable, but the point is, that skipping test like this is kind of hackish and not straight forward. I think we can live with one case like this, but if we encounter few more in the future it will be good to rethink testing approach.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-paste-from-office Oct 9, 2019
@mlewand mlewand added this to the unknown milestone Oct 9, 2019
@mlewand mlewand added status:discussion type:task This issue reports a chore (non-production change) and other types of "todos". package:paste-from-office labels Oct 9, 2019
@pomek pomek removed this from the unknown milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 8, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:paste-from-office resolution:expired This issue was closed due to lack of feedback. status:discussion status:stale type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

No branches or pull requests

4 participants