Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Autoformat feature should not require the Bold, Italic, etc. features #2365

Closed
Reinmar opened this issue Oct 31, 2016 · 4 comments · Fixed by ckeditor/ckeditor5-autoformat#27
Closed

The Autoformat feature should not require the Bold, Italic, etc. features #2365

Reinmar opened this issue Oct 31, 2016 · 4 comments · Fixed by ckeditor/ckeditor5-autoformat#27
Labels
package:autoformat type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 11

Comments

@Reinmar
Copy link
Member

Reinmar commented Oct 31, 2016

The idea was that it will enable autoformatting for the other features, if they are enabled.

This means that we need to check whether the other features are enabled. I thought that we'd be able to do that in the Autoformat.init() method, but unfortunately, this won't be reliable. We need to check this later on, on the runtime. Alternatively, we need to introduce some "post init" event in the editor.
@Reinmar
Copy link
Member Author

Reinmar commented Oct 31, 2016

There's another issue caused by this: https://github.com/ckeditor/ckeditor5-heading/issues/40.

@Reinmar
Copy link
Member Author

Reinmar commented Nov 7, 2016

Remember about cleaning up package dependencies after fixing this.

@pjasiun
Copy link

pjasiun commented Dec 30, 2016

Similar: https://github.com/ckeditor/ckeditor5-autoformat/issues/17.

@Reinmar
Copy link
Member Author

Reinmar commented Dec 30, 2016

This issue can be easily fixed now, because we have Plugin#afterInit.

@szymonkups szymonkups self-assigned this May 15, 2017
oleq referenced this issue in ckeditor/ckeditor5-autoformat May 18, 2017
@oleq
Merge pull request #27 from ckeditor/t/5
d22c5b6 
Fix: The Autoformat should not require other features. Closes #5 #17.

NOTE: The Autoformat feature doesn't require Bold, Italic, Heading, etc. any longer. In order to make the most of the plugin, please make sure that relevant features are loaded in your editor.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-autoformat Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added type:improvement This issue reports a possible enhancement of an existing feature. package:autoformat labels Oct 9, 2019
@szymonkups szymonkups mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:autoformat type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 11
Development

Successfully merging a pull request may close this issue.

Removed features dependencies, checking commands to enable formatting ckeditor/ckeditor5-autoformat
4 participants
@Reinmar @pjasiun @szymonkups @mlewand