Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text part language dropdown is unusable when having a large number of allowed languages #15715

Closed
DuaelFr opened this issue Jan 17, 2024 · 2 comments
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:language resolution:duplicate This issue is a duplicate of another issue and was merged into it. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@DuaelFr
Copy link

DuaelFr commented Jan 17, 2024

📝 Provide detailed reproduction steps (if any)

  1. configure an editor with the TextPartLanguage plugin enabled
  2. allow more than 30-40 languages (more than necessary to have a dropdown bigger than your viewport)
  3. open the dropdown and try to get to the end of the list

✔️ Expected result

You can scroll inside the dropdown to get to the language you want.

❌ Actual result

You need to scroll down the page (if possible) to get to the language you want. Under certain circumstances (global CSS preventing scrolling) you cannot reach the part of the dropdown overflowing the screen.

❓ Possible solution

Use CSS to make that dropdown scrollable when its height is bigger than the viewport or the editor.
For example:

.ck-text-fragment-language-dropdown .ck-dropdown__panel {
  overflow-x: auto;
  max-height: var(--ck-dialog-max-height);
}

📃 Other details

  • Browser: All
  • OS: All
  • First affected CKEditor version: 5
  • Installed CKEditor plugins: Doesn't matter

This issue has been detected first on Drupal: https://www.drupal.org/project/drupal/issues/3375157


If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@DuaelFr DuaelFr added the type:bug This issue reports a buggy (incorrect) behavior. label Jan 17, 2024
@Witoso
Copy link
Member

Witoso commented Jan 18, 2024

Thanks for the request!

@Witoso Witoso added the domain:ui/ux This issue reports a problem related to UI or UX. label Jan 18, 2024
@oleq
Copy link
Member

oleq commented Jan 18, 2024

This is a duplicate of #952. We tried to make it work in the past but there were issues and we had to revert changes. I think we could make a second attempt now that tooltips are floating elements and are no longer hosted by buttons.

@Witoso Witoso closed this as not planned Won't fix, can't repro, duplicate, stale Jan 18, 2024
@Witoso Witoso added the resolution:duplicate This issue is a duplicate of another issue and was merged into it. label Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:language resolution:duplicate This issue is a duplicate of another issue and was merged into it. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

3 participants