Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the editor for memory leaks after interacting with it #1461

Closed
jodator opened this issue Jan 15, 2019 · 2 comments
Closed

Check the editor for memory leaks after interacting with it #1461

jodator opened this issue Jan 15, 2019 · 2 comments
Labels
resolution:expired This issue was closed due to lack of feedback. status:stale type:performance This issue reports a performance issue or a possible performance improvement. type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@jodator
Copy link
Contributor

jodator commented Jan 15, 2019

During debugging/fixing the memory leaks of an editor that is created/destroyed (#1341) I've narrowed down my scope to only instantiating and destroying the editor. But reviewing some parts of code I've discovered that some features like FocusCycler, MutationObservers adds listeners to DOM nodes and they can (AFAIR) add them during the editor lifecycle.

In other words we still need to check the editor for any memory leaks that may occur while interacting with the editor. This will include:

  • typing
  • using undo/redo
  • moving the focus over the toolbar
  • selecting widgets (table, image, media, ...) and interacting with widget toolbars
  • pasting
  • pasting images
  • embedding media
  • selecting text, elements, moving selection, etc

If we found out any memory leaks (and I strongly believe that we still may) we should introduce another set of automated tests if possible.

@jodator jodator added status:confirmed type:task This issue reports a chore (non-production change) and other types of "todos". labels Jan 15, 2019
@jodator jodator self-assigned this Jan 15, 2019
@jodator jodator changed the title Check Memory of editor after some interaction Check the editor for memory leaks after interacting with it Jan 15, 2019
@Reinmar Reinmar added this to the backlog milestone Mar 25, 2019
@mlewand mlewand added the type:performance This issue reports a performance issue or a possible performance improvement. label Feb 14, 2020
@pomek pomek removed this from the backlog milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 4, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution:expired This issue was closed due to lack of feedback. status:stale type:performance This issue reports a performance issue or a possible performance improvement. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

No branches or pull requests

5 participants