ContextWatchdog should be able to exclude singletons

[oleq]

📝 Provide a description of the improvement

The new tooltip manager system works as a singleton. Its only instance is shared across all editors under editorui.ui.tooltipManager property.

This is unprecedented and it makes the context watchdog go off the rails when and error is thrown.

Watchdog uses areConnectedThroughProperties() to determine which editor instances to restart in case of an error. It has a logic that ignores certain things hardcoded in the getSubNodes() helper, though. When an error is thrown in one editor, the connection through editor.ui.tooltipManager is discovered, and all editors are restarted, which is incorrect.

To workaround this issue, we had to set the temporary this._watchdogExcluded = true; flag in the TooltipManager instance (and getSubNodes()) to prevent the watchdog from making this kind of connection. This is not pretty to say the least and probably we need a better logic to discover singletons and manage them.

cc @scofalik

---

If you'd like to see this improvement implemented, add a 👍 reaction to this post.

[CKEditorBot]

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

[CKEditorBot]

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).