Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS] Revise code style guide to cover TypeScript #11723

Open
Tracked by #12027
arkflpc opened this issue May 6, 2022 · 2 comments
Open
Tracked by #12027

[TS] Revise code style guide to cover TypeScript #11723

arkflpc opened this issue May 6, 2022 · 2 comments
Labels
domain:ts squad:core Issue to be handled by the Core team. type:docs This issue reports a task related to documentation (e.g. an idea for a guide).

Comments

@arkflpc
Copy link
Contributor

arkflpc commented May 6, 2022 •
edited
Loading

We need to revise Code style to cover TypeScript features.

It'd also be a good idea to write here tips & tricks that we learn while porting the code.

Part of #11708.
@arkflpc arkflpc added squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos". domain:ts type:docs This issue reports a task related to documentation (e.g. an idea for a guide). and removed type:task This issue reports a chore (non-production change) and other types of "todos". labels May 6, 2022
@arkflpc arkflpc changed the title [TS MVP] Update style guide to cover TypeScript [TS MVP] Revise style guide to cover TypeScript May 6, 2022
@arkflpc arkflpc mentioned this issue May 23, 2022
Merged
@Reinmar Reinmar mentioned this issue Jul 21, 2022
Closed
@Witoso Witoso mentioned this issue Apr 4, 2023
Closed
12 tasks
@Witoso
Copy link
Member

Witoso commented Apr 26, 2023

To follow up with some team brainstorming.

@Witoso Witoso changed the title [TS MVP] Revise style guide to cover TypeScript [TS MVP] Revise code style guide to cover TypeScript May 10, 2023
@Witoso Witoso changed the title [TS MVP] Revise code style guide to cover TypeScript [TS] Revise code style guide to cover TypeScript May 10, 2023
@arkflpc
Copy link
Contributor Author

arkflpc commented May 24, 2023 •
edited by Witoso
Loading

Draft of scope:

  • Review current examples
  • Add new rules from esLint
  • Module import formatting
  • Accessibility
  • Mixins
  • Creating read-only properties

If a decision needs to be made, write in draft possible solutions, and let's discuss them on the team level.

@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label May 29, 2023
@CKEditorBot CKEditorBot removed the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain:ts squad:core Issue to be handled by the Core team. type:docs This issue reports a task related to documentation (e.g. an idea for a guide).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@arkflpc @Witoso @CKEditorBot