All editor features should consume attributes they put in the model during upcast #11532
Labels
package:code-block
package:engine
package:html-support
package:image
package:language
package:media-embed
package:style
resolution:expired
This issue was closed due to lack of feedback.
squad:core
Issue to be handled by the Core team.
status:stale
type:bug
This issue reports a buggy (incorrect) behavior.
📝 Provide detailed reproduction steps (if any)
In #11530 we came across an issue with GHS (double-)consuming the
src
of an image and creating a mess. The issue was crazy but the fix pretty straightforward.While fixing this my gut told me there could be other features that also touch attributes in the upcast pipeline but not consume them, which would spawn dozens of #11530 clones in the future.
To check this, I created a simple plugin
and ran it against the all-features manual test. You can add it straight to
plugins: []
or better yet: put it in the implementation ofParagraph
because it's everywhere and you can then run just any test (manual or automatic).I discovered there are plenty of plugins that leave things unconsumed, these are just a few examples:
CodeBlock
Using code blocks + GHS + text direction
MediaEmbed
TextPartLanguage
ImageInline
Image
againMore
Image
We need to review all of them at patch them up because otherwise we'll hit it again and again while working on GHS. Just keep in mind that some attributes may not need to be consumed if they were ignored by the feature (not transferred to the model).
If you'd like to see this fixed sooner, add a 👍 reaction to this post.
The text was updated successfully, but these errors were encountered: